Skip to content

STY: pin ruff version exactly and fix new violations in v0.16.0 - #411

Merged
zacharyburnett merged 1 commit into
OpenAstronomy:mainfrom
neutrinoceros:sty/pin-ruff
Aug 11, 2026
Merged

STY: pin ruff version exactly and fix new violations in v0.16.0#411
zacharyburnett merged 1 commit into
OpenAstronomy:mainfrom
neutrinoceros:sty/pin-ruff

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

No description provided.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

errors are unrelated and addressed in #410.
Note that both PRs include updates to helper scripts (and consequently to their hashes), which will necessarily lead to some merge conflicts. I advise merging one, then rebase/update the other one.

@zacharyburnett

zacharyburnett commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

we can also explicitly select the old default ruff rules and add in the new ones one at a time, like in spacetelescope/romancal#2400; the docs say the pre-0.16.0 default rules were:

select = ["E4", "E7", "E9", "F"]

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

That'd be fine with me, just not guaranteed to work through future (implicit) upgrades. Let me know what you prefer. In the mean time, I'll just resolve merge conflicts.

@zacharyburnett zacharyburnett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then, lets go with the new default rules that ship with 0.16.0, they seem sensible enough and don't introduce too many changes

@zacharyburnett
zacharyburnett merged commit 2ee1c83 into OpenAstronomy:main Aug 11, 2026
121 of 122 checks passed
@neutrinoceros
neutrinoceros deleted the sty/pin-ruff branch August 11, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants