Revert "Merge pull request #706 from OpenConext/release/680" - #719
Merged
Conversation
EricvanSchaik
requested review from
baszoetekouw,
crosmuller and
mrvanes
and removed request for
baszoetekouw,
crosmuller and
mrvanes
July 24, 2026 13:40
Closed
EricvanSchaik
force-pushed
the
feature/add-back-sram-roles
branch
from
September 3, 2026 14:03
5912ecb to
bd6613a
Compare
EricvanSchaik
marked this pull request as ready for review
September 3, 2026 14:28
EricvanSchaik
force-pushed
the
feature/add-back-sram-roles
branch
from
September 3, 2026 15:03
bd6613a to
c67ba1e
Compare
baszoetekouw
approved these changes
Sep 4, 2026
baszoetekouw
left a comment
baszoetekouw
left a comment
Member
There was a problem hiding this comment.
checked that this works on test and acc and doesn't break other roles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4fdcf28, reversing changes made to 4664b6a.