Pin TPS6699x PD CFU fix - #954
Merged
asasine merged 4 commits intoSep 8, 2026
Merged
Conversation
Use the confirmed upstream revision containing the PD CFU timeout fixes instead of the v0.1.1 tag. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
asasine
requested review from
felipebalbi,
kurtjd,
tullom and
williampMSFT
and
a lite review from Copilot
September 3, 2026 23:11
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward dependency pin with the corresponding lockfile update and no additional code-path modifications.
Pull request overview
Pins the workspace tps6699x git dependency to a specific commit so type-c-service (and other workspace users) reliably consume the PD CFU timeout fixes referenced in the PR description.
Changes:
- Switch
tps6699xfrom thev0.1.1tag to a fixed gitrevin workspace dependencies. - Update
Cargo.lockto reflect the newtps6699xsource revision.
File summaries
| File | Description |
|---|---|
| Cargo.toml | Pins the workspace tps6699x dependency to the specified commit revision. |
| Cargo.lock | Updates the resolved git source for tps6699x to match the new pinned revision. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep the standalone example workspaces on the same TPS6699x revision as the root workspace so their locked clippy checks resolve without modifying lockfiles. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kurtjd
previously approved these changes
Sep 3, 2026
Replace the pre-merge revision with the authoritative commit merged into the upstream stable-v0.1.y branch. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 924bf312-4bcf-4658-9b15-3ddb146548b2
kurtjd
approved these changes
Sep 8, 2026
asasine
enabled auto-merge (squash)
September 8, 2026 16:51
jerrysxie
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/OpenDevicePartnership/tps6699x/releases/tag/v0.1.2