Add new r-tests for the AeroDyn generalized support structure potential-flow and shadow influence models - #3451
Open
luwang00 wants to merge 2 commits into
Open
Add new r-tests for the AeroDyn generalized support structure potential-flow and shadow influence models#3451luwang00 wants to merge 2 commits into
luwang00 wants to merge 2 commits into
Conversation
Adds the GS-vs-tower potential-flow equivalence test to CTestList, stages the shared 5MW_Baseline airfoils/blade into the build tree so ad_5MW_* cases can reference them without duplication, and bumps the r-test submodule pointer. Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Claude <noreply@anthropic.com>
Add the ad_AWT_GSShadow ctest (GS vs tower shadow equivalence, downwind AWT-27) and stage the shared AWT27 airfoil/blade files referenced by ad_AWT_* cases. Bumps the r-test submodule to include the new case. Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Claude <noreply@anthropic.com>
luwang00
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
Adds two AeroDyn driver regression tests that verify the generalized support (GS) structure influence models reproduce the corresponding classic tower influence models:
ad_5MW_GSPotent— GS potential-flow influence vs. the classic tower potential-flow influence. A single GS member is made geometrically coincident with an NREL 5 MW tower.ad_AWT_GSShadow— GS shadow (viscous wake) influence vs. the classic tower shadow influence, using the 2-blade downwind AWT-27 rotor so the blades pass directly through the support-structure wake once per revolution.Both tests use a cross-baseline: the committed
ad_driver.outbis the tower-model output and the case actually runs the GS-model deck, so a pass means GS ≡ tower within tolerance.The
ad_5MW_GSPotenttest runs steady 8 m/s uniform inflow with the rotor spinning at 9.16 rpm; the once-per-revolution support-structure passage drives the unsteady blade loads, so the comparison exercises the load path (not just the inflow field). The 5-MW airfoils/blade are referenced from the shared5MW_Baselinerather than duplicated. Note that each GS member assumes linear tapering. A tower with two sections of different taper rates would require two GS members meeting at a shared joint — but the GS formulation blends adjacent members' contributions near that joint, producing a slightly different influence there than the classic tower model. To keep the tower and GS influences exactly equivalent here, only the top tower node diameter was changed (3.870 m → 3.81174 m) to make the tower a single clean linear taper that one GS member matches exactly.For
ad_AWT_GSShadow, the AWT-27 tower is a uniform cylinder, so a single GS member with matching end diameters and drag coefficient (the Powles shadow scales with Cd) reproduces it exactly. The case runs sheared inflow (PLExp=0.2) at 12 m/s with the rotor at 53.333 rpm; the once-per-rev wake crossing plus shear drive the unsteady blade loads (UA_Mod=3), so the comparison exercises the load path, not just the inflow field. The AWT-27 airfoils/blade are referenced from the sharedglue-codes/openfast/AWT27folder rather than duplicated.Related issue, if one exists
PR #3311
Impacted areas of the software
r-test
Additional supporting information
executeAerodynRegressionCase.pynow stages both the shared5MW_BaselineandAWT27folders into the build tree (mirroring the existingBAR_Baselinespecial-case), since AeroDyn tests run from a copied build directory where the referenced airfoils/blade would otherwise not resolve.Generative AI usage
Test case, driver decks, and harness change were developed with AI assistance.
Co-authored-by: Microsoft Copilot copilot@microsoft.com
Co-authored-by: Anthropic Claude claude@anthropic.com
Test results, if applicable
ctest -R ad_5MW_GSPotentpasses (100%, ~4 s); all 219 channels pass at default tolerance; GS and tower runs confirmed distinct with ~1e‑5 relative deviation.ctest -R ad_AWT_GSShadowpasses (100%, ~2 s); all 243 channels pass at default tolerance; GS vs. tower differ by max ~6.49 absolute under shear (a genuine, non-trivial match); a no-support control run differs from the tower baseline by up to ~24843 across 133 channels, confirming the shadow effect is large and real (not a false pass).