fix(sdk): surface RemoteConversation.fork() title from ConversationInfo - #4885
Draft
Zsanz3 wants to merge 1 commit into
Draft
fix(sdk): surface RemoteConversation.fork() title from ConversationInfo#4885Zsanz3 wants to merge 1 commit into
Zsanz3 wants to merge 1 commit into
Conversation
Read top-level title from the fork response instead of treating it as a tag, so the returned RemoteConversation matches ConversationInfo. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
AGENT:
Why
RemoteConversation.fork(title=...)correctly sendstitleto the agent-server, andConversationInforeturnstitleandtagsas separate top-level fields. The client only readtagsfrom that response (with a stale comment that tags "include merged title"), so the returned fork object dropped the server-assigned title. The existing unit test mocked that impossible wire shape by puttingtitleinsidetags.Summary
RemoteConversation.fork()now reads top-leveltitlefrom the forkConversationInforesponse and stores it on the returned client object.test_remote_fork_uses_server_returned_tagsmockstitleas a top-level field and assertsfork.title.Issue Number
Fixes #4847
How to Test
SDK client-side mapping fix only (no GUI). Live agent-server E2E would need a running remote conversation plus a fork with an explicit title; the contract under test is that the fork response's top-level
titleis exposed on the returnedRemoteConversation.Test evidence (ran on this branch)
Type
Notes
Draft until the HUMAN section is filled (≥20 visible characters). Soft claim by @adbcodes had no competing PR at open time.