Conversation
- MarketoView: drop an unreachable self-assignment block - AssociationRuleView / ObjectTypesDialog: remove conditions that are always true - Remove dead local assignments and the unused showRelationships helper (RelationshipWidget, ManagedListView, SchemaEditorView, CorrelationQueryBuilderView, GenericEditResourceView, FormGenerationUtils, SocialIdentitiesTab) - SSH connector template: drop a duplicated attribute; Salesforce template: drop an empty id Resolves CodeQL alerts #750-#752, #881, #885-#892, #897, #898, #909.
vharseko
added
javascript
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| obj.generateTemplateFromFormProperties = function(definition, formValues) { | ||
| var property, formTemplate = "", formFieldType, formFieldDescription, i; | ||
| var property, formTemplate = "", formFieldDescription, i; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last of the warning-level CodeQL batches: the JavaScript/template findings in the admin and end-user UI. 14 alerts fixed, 3 dismissed as false positives. No behavioural change — dead code, conditions that were always true, and two template attributes.
redundant-assignmentMarketoView.jsif (_.isNull(x) && _.isObject(x)) { x = x; }— the condition can never hold and the body assigned the value to itself; removed.trivial-conditionalAssociationRuleView.js!addedbranches,addedis always true:else if (added && …)→else if (…),else if (added)→else.trivial-conditionalObjectTypesDialog.jsreturn jsonEditorFormat || false— always an object.useless-assignment-to-localGenericEditResourceView.jsshowRelationshipswas declared and assigned but never called; removed. (Different hunk from the one #204 touches in this file.)CorrelationQueryBuilderView.jsshowExpressionMenucomputedclickedEleand never used it — the menu is a Bootstrap dropdown; the handler now only stops the default action.RelationshipWidget,ManagedListView,SchemaEditorView×3,FormGenerationUtils,SocialIdentitiesTabrefreshSettings,iconinitial value,forArray = false×2,prop = _.extend(prop, …),formFieldType,oauthWindow).duplicate-html-attributeSSHConnector_1.4.htmldata-validator-event.malformed-html-idSalesforce_2.0.htmlid=""on a hidden input.Dismissed as false positives: #882–#884
SyncDelegate.js—object/sourceare read by the user-supplied condition/transform scripts evaluated througheval(...)on the following lines.Test plan
openidm-ui-common,openidm-ui-adminandopenidm-ui-enduser: eslint clean, QUnit 93/93 (admin) and 2/2 (end-user), BUILD SUCCESS