Security: Server-Side Request Forgery (SSRF) in /api/fetch - #511
Closed
tomaioo wants to merge 1 commit into
Closed
Conversation
The `/api/fetch` endpoint takes a URL from the user request body and fetches it server-side without any validation. An attacker can use this to force the server to make requests to internal network resources (e.g., `http://localhost`, `http://169.254.169.254`), potentially exposing internal services or cloud metadata. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
|
Fixed this in #513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Server-Side Request Forgery (SSRF) in /api/fetch
Problem
Severity:
Critical| File:src/pages/api/fetch.ts:L6The
/api/fetchendpoint takes a URL from the user request body and fetches it server-side without any validation. An attacker can use this to force the server to make requests to internal network resources (e.g.,http://localhost,http://169.254.169.254), potentially exposing internal services or cloud metadata.Solution
Implement a strict allowlist of permitted domains or URL patterns (e.g., only allowing specific external domains that the application needs to fetch from). Reject any requests pointing to internal or link-local IP addresses.
Changes
src/pages/api/fetch.ts(modified)