Skip to content

Move ISSUE-033 and ISSUE-034 to completed.md, and finish ISSUE-034 in docs/codebase - #22

Merged
Sellafield merged 2 commits into
OpenPerpetuum:developfrom
meketreve:backlog-033-034-done
Aug 13, 2026
Merged

Move ISSUE-033 and ISSUE-034 to completed.md, and finish ISSUE-034 in docs/codebase#22
Sellafield merged 2 commits into
OpenPerpetuum:developfrom
meketreve:backlog-033-034-done

Conversation

@meketreve

@meketreve meketreve commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Follow-up bookkeeping for the two fixes you merged this morning: #19 (ISSUE-033) and #20 (ISSUE-034). The Backlog Rules in CLAUDE.md say to update related backlog items after implementation and to move completed items to completed.md, which is what this does — plus the part of ISSUE-034 that the original entry had missed.

What changed

  • docs/backlog/issues.md — ISSUE-033 and ISSUE-034 entries removed; ISSUE-035 stays, still TODO. # Last ID used is untouched.
  • docs/backlog/completed.md — both entries appended with Status: DONE, their ### Proposed Fix replaced by a ### Fix describing what actually shipped, plus ### Files Changed and a note naming the merged PR.
  • docs/codebase/TESTING.md, STACK.md, STRUCTURE.md — the --GameRoot correction from Fix the run command and ten broken paths in CLAUDE.md #20, applied where it was still missing.

The ISSUE-034 entry records which of the two options was taken for the two .claude/knowledge/architecture.md references: repointed at docs/codebase/ARCHITECTURE.md rather than creating the missing file. If you would rather have the file, say so and both the code change and this entry are two lines to flip.

One unrelated tidy: the three entries added in #18 were missing the --- separator that every other entry in issues.md carries. Removing two of them left ISSUE-035 and ISSUE-032 adjacent with no rule between them, so the separator is restored there.

Finishing ISSUE-034

ISSUE-034 surveyed CLAUDE.md only, so #20 fixed the run command there and nowhere else. The same mistake is still in three files under docs/codebase/:

File Text
TESTING.md:34 dotnet run -- --GameRoot "E:\PerpetuumServer2\data"
STACK.md:53 McMaster.Extensions.CommandLineUtils described as parsing a --GameRoot option
STRUCTURE.md:194 Program.cs described as parsing --GameRoot

src/Perpetuum.Server/Program.cs declares the game root positionally — app.Argument("<GAMEROOT>", ...) on line 15 — so the option does not exist and the documented command fails with Unrecognized option '--GameRoot'.

TESTING.md is the one that matters most. The repository has no automated test suite, so running the server by hand is the only validation path a contributor has, and the command given for it could not work. Closing ISSUE-034 as done while that line stood seemed worse than widening the entry, so the completed.md entry now covers all four files and its title reflects the wider scope.

--GameRoot remains valid for Perpetuum.ServerService2, which reads GameRoot from appsettings.json, and is untouched. Five further occurrences under docs/superpowers/plans/ are dated records of plans already carried out, so they are left as written rather than rewritten after the fact — say the word if you would rather they were updated too.

Note on convention

ISSUE-031 and ISSUE-032 are DONE but still sit in issues.md, so "move when complete" does not look like a hard rule in practice. I moved these two because completed.md is where the rule points; if you would rather keep recent DONE entries in place, drop the completed.md half of this PR and I will just flip the status instead.

Documentation only — no code, no build impact. Does not touch anything in #21.

🤖 Generated with Claude Code

Both fixes are merged - PR OpenPerpetuum#19 for ISSUE-033 and PR OpenPerpetuum#20 for ISSUE-034 -
so the entries are set to DONE and moved, per the Backlog Rules in
CLAUDE.md.

Each entry now records what actually shipped: the Proposed Fix section
is replaced by a Fix section describing the change, a Files Changed
section, and a note naming the merged PR. For ISSUE-034 the Fix also
states which of the two options was taken for the two
.claude/knowledge/architecture.md references - they were repointed at
docs/codebase/ARCHITECTURE.md rather than creating the missing file.

Also restores the --- separator between entries in issues.md. The three
entries added in PR OpenPerpetuum#18 were missing it, and removing two of them left
ISSUE-035 and ISSUE-032 adjacent with no rule between them.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@meketreve
meketreve force-pushed the backlog-033-034-done branch from 37a0034 to 70b2feb Compare August 13, 2026 11:13
@meketreve

Copy link
Copy Markdown
Contributor Author

Rebased onto develop now that #21 is merged. No conflict: your ISSUE-036/037/038 entries and the Last ID used bump to 038 are untouched, this PR still only removes the two ISSUE-033/034 blocks from issues.md and appends them to completed.md.

PR OpenPerpetuum#20 fixed the run command in CLAUDE.md, but ISSUE-034 had only surveyed
that file. The same mistake sits in three files under docs/codebase/, which
is the authoritative documentation set:

- TESTING.md gives the manual-testing command as
  dotnet run -- --GameRoot "<path>"
- STACK.md describes McMaster.Extensions.CommandLineUtils as parsing a
  --GameRoot option
- STRUCTURE.md describes Program.cs as parsing --GameRoot

src/Perpetuum.Server/Program.cs declares the game root positionally, via
app.Argument("<GAMEROOT>", ...), so the option does not exist and the
documented command fails with Unrecognized option '--GameRoot'.

TESTING.md matters most of the three: the repository has no automated test
suite, so running the server by hand is the only validation path a
contributor has, and the command given for it could not work.

Widen the ISSUE-034 entry in completed.md to cover these three files rather
than closing it as done while the same defect remains in the docs it points
contributors at.

--GameRoot remains valid for Perpetuum.ServerService2, which reads GameRoot
from appsettings.json, and is untouched. Five further occurrences under
docs/superpowers/plans/ are dated records of plans already carried out and
are left as written.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@meketreve meketreve changed the title Move ISSUE-033 and ISSUE-034 to completed.md Move ISSUE-033 and ISSUE-034 to completed.md, and finish ISSUE-034 in docs/codebase Aug 13, 2026
@Sellafield
Sellafield merged commit eedffa8 into OpenPerpetuum:develop Aug 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants