Skip to content

fixes hipercdecode buffer overflow detected #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoesCat wants to merge 1 commit into
base: main-fixes
Choose a base branch
from
Open

fixes hipercdecode buffer overflow detected #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions hipercdecode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ int PrintHexOffset = 0;
FILE *FpRaw[4];
FILE *FpDec[4];

unsigned char blk[50*1024*1024];

void
debug(int level, char *fmt, ...)
{
Expand Down Expand Up @@ -143,7 +145,6 @@ print_bih(unsigned char bih[20])
((yd >> bih[1]) + ((((1UL << bih[1]) - 1) & xd) != 0) + l0 - 1) / l0,
bih[1] - bih[0], bih[2]);
}
unsigned char blk[50*1024*1024];

void
decode(FILE *fp)
Expand Down Expand Up @@ -220,7 +221,6 @@ decode(FILE *fp)
{
int blklen;
int i;
// unsigned char blk[50*1024*1024];

if (PrintOffset) printf("%d: ", curOff);
else if (PrintHexOffset) printf("%6x: ", curOff);
Expand All @@ -229,8 +229,10 @@ decode(FILE *fp)
if (rc != 1) break;
curOff += 4;
reclen -= 4;

blklen = be32(blklen);
if (blklen >= sizeof(blk))
error(1, "BLKLEN=%d exceeds blk[%d] size.\n", blklen, sizeof(blk));
rc = fread(&blk, blklen, 1, fp);
if (rc != 1) return;
curOff += blklen;
Expand Down