minutes to read - #233
Merged
Merged
Conversation
Member
|
Hi, thanks for the fix, but your work is conflicting with the current state of the site. Probably you did it before I accepted some PRs yesterday. Could you resolve the conflicts/rebase to the current repo state? Thanks. |
Member
|
According to the screenshot this is exactly what I need. |
Contributor
Author
|
@tillkamppeter all conflicts are resolved |
tillkamppeter
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225
This PR improves the syntactical error in the /app/news/page.tsx .
Problem -
readTime: typeof data.readTime === "string" ? data.readTime : "less than 1 minute read",The project uses the readingTime package to calculate the time that is taken to read a particular article or news/ so if we are using readingTime then why we are passing readTime as a string. so even if you pass it like that , there will be no use , It will always show less than 1 minute read.
what I did -
import the readingTime package pass it to a function name readTimeText and calculate the time taken and render it , However if an article/news is taken less than 1 minute to read then show less than 1 minute read.
Hope this is what you are looking for.
