Document sharing dynamic access keys with users - #9
Open
angelodlfrtr wants to merge 2 commits into
Open
Conversation
Greptile SummaryThe PR documents how operators share dynamic access keys and strengthens translation link validation by replacing broad count exceptions with exact exclusions.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| docs/vpn/management/dynamic-access-keys.md | Adds accurate user-sharing, credential-protection, and revocation guidance for dynamic access keys. |
| scripts/verify_translations.py | Replaces broad link-count exceptions with exact English-only link exclusions and validates known link swaps without leaving the previously reported URL-checking bypass. |
Reviews (4): Last reviewed commit: "Validate translated links in docs with k..." | Re-trigger Greptile
angelodlfrtr
force-pushed
the
docs/dynamic-access-keys.md
branch
from
September 1, 2026 14:36
796779c to
52ca671
Compare
Contributor
|
You can delete the translated additions. We don't use machine translation since we're not yet sure it's reliable enough and we're not able to double-check it. We intend to set up a translation pipeline with a vendor later, but for now we just keep new articles in english only. |
Add a "Share the Key with Your Users" section to the dynamic access keys page explaining the ssconf:// scheme: how to derive the key from the hosted configuration URL, naming the client entry with a URL fragment, and warnings that the key URL is a credential and that deleting the hosted configuration does not revoke access. Record the resulting code block, link, and admonition differences as known exceptions in the translation verifier, matching how other post-export English additions are handled, and drop a stale exception for vpn/advanced/websockets whose counts already match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
angelodlfrtr
force-pushed
the
docs/dynamic-access-keys.md
branch
from
September 1, 2026 15:39
52ca671 to
a796283
Compare
Replace the KNOWN_LINK_COUNT_DIFFS count exceptions, which skipped URL-by-URL link comparison entirely for the affected docs, with a KNOWN_ENGLISH_ONLY_LINKS table pinning the exact English link indices that have no translated counterpart. Those indices are removed before comparison and every remaining link must still match the translation URL-by-URL, so an omitted, mistyped, or replaced localized destination now fails verification. Also validate KNOWN_LINK_SWAPS positions as a set, so a replaced URL at a swapped position is caught instead of being skipped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "Share the Key with Your Users" section to the dynamic access keys page explaining the ssconf:// scheme: how to derive the key from the hosted configuration URL, naming the client entry with a URL fragment, and warnings that the key URL is a credential and that deleting the hosted configuration does not revoke access.
Translate the new section into all 17 locales, keeping code blocks identical to the English source as required by the translation verifier, and drop the now-unneeded verifier exceptions for this page along with a stale entry for vpn/advanced/websockets whose counts already match.