Conversation
doneill
requested review from
Alex79373,
hugo07E8 and
leo-ori
as code owners
September 15, 2026 20:39
There was a problem hiding this comment.
🟡 Changes recommended
Field grouping must safely handle inherited field names.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds V2 support for “matches any” conditionals by grouping conditions by field.
Changes:
- Groups same-field conditions with
anyOf. - Combines different fields with
allOf. - Adds tests and bumps the package to beta.35.
File summaries
| File | Summary |
|---|---|
test/v2.conditions.test.ts |
Adds tests for same-field and cross-field condition behavior. |
src/v2/conditions.ts |
Implements field grouping. A moderate issue remains for inherited field names such as constructor, toString, and __proto__ (3 votes). |
package.json |
Updates the beta version. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+346
to
+359
| const groupConditionsByField = (conditions: V2Condition[]): V2Condition[][] => { | ||
| const order: string[] = []; | ||
| const groups: Record<string, V2Condition[]> = {}; | ||
|
|
||
| conditions.forEach((condition) => { | ||
| if (!groups[condition.field]) { | ||
| groups[condition.field] = []; | ||
| order.push(condition.field); | ||
| } | ||
| groups[condition.field].push(condition); | ||
| }); | ||
|
|
||
| return order.map((field) => groups[field]); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for #45
Proposed Changes
conditionalMatchparameterImplementation Test
In React Native client app, e.g. EarthRanger
Unit Tests