Recognize named Blade slot closing tags - #431
Open
shuvroroy wants to merge 1 commit into
Open
Conversation
Accept a named slot's matching closing tag as well as the bare x-slot closer. Previously a valid <x-slot:title>...</x-slot:title> was diagnosed as mismatched and its component span remained unclosed. Cover both valid closing spellings and mismatched closers with regression tests, and document the editor-visible fix in the changelog.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shuvroroy
marked this pull request as ready for review
September 9, 2026 06:53
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A named Blade slot such as
<x-slot:title>Latest update</x-slot:title>was reported as a mismatched component tag. Accept the matching named closer as well as the existing bare</x-slot>spelling, while still reporting unrelated closers.Regression tests cover tag spans and balance diagnostics for both valid spellings and invalid closers. The existing Laravel demo already exercises the named closer.
Validation: full Cargo tests, library and all-target Clippy with warnings denied, formatting, PHP syntax checks, and both demo assertion suites pass. Laravel analysis reports exactly its three intentional diagnostics. All changed executable Rust lines are covered.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,examples/)config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.