Infer string keys for UUID and ULID models - #438
Open
shuvroroy wants to merge 1 commit into
Open
Conversation
Recognize HasUuids and HasUlids through composed traits and parent models when resolving implicit primary keys. Preserve existing property precedence and custom key names. Add provider and LSP regression tests, Laravel demos with runtime assertions, and changelog documentation. Remove the completed backlog item.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models using Laravel's
HasUuidsorHasUlidstraits currently expose an implicit integer primary key. This change resolves that key asstring, including traits composed through other traits or inherited from parent models, so completion, hover, and diagnostics agree with the model's identifier type.Trait detection uses bounded traversal and avoids cloning class metadata. Custom primary-key names and existing property precedence are preserved. Includes regression tests, Laravel playground examples with runtime assertions, a changelog entry, and removal of the completed L12 backlog item.
Validation
cargo llvm-cov: 14,730 passed, 2 ignored.main.cargo clippy --fix --allow-dirty -- -D warnings,cargo clippy --all-targets -- -D warnings, andcargo fmt --checkpass.Checklist
docs/CHANGELOG.md.No config schema changes are required.