Improve translation completion, navigation, and quick fixes - #439
Open
shuvroroy wants to merge 6 commits into
Open
Improve translation completion, navigation, and quick fixes#439shuvroroy wants to merge 6 commits into
shuvroroy wants to merge 6 commits into
Conversation
Retain exact key ranges when decoding JSON translations, including escaped keys and provider paths. Use the shared reference index for requests from JSON declarations and read unsaved buffers during definition lookup. Add navigation regressions and a JSON translation example with a runtime assertion.
Decode PHP translation literals before matching JSON and PHP declarations, retain source ranges, and reject non-JSON whitespace. Read Blade reference positions in the symbol map coordinate space before translating them back to the template. Cover stale diagnostics, removed files, invalid paths, nested calls, and unknown replacement arrays. Complete the translation-depth documentation and backlog cleanup. Validation: 14,785 Rust tests passed; all 693 added executable production Rust lines covered. Clippy, formatting, doctests, PHP syntax checks, and demo runtime assertions passed.
shuvroroy
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel translation support now covers both
lang/andresources/lang/throughout the editor:A shared lazy catalog avoids repeated directory scans and parsing, and refreshes for buffer edits, file changes, and provider updates. The changes also correct escaped-key matching and Blade reference coordinates.
Validation:
cargo llvm-covagainstmain.<x-slot:title>diagnostic covered by the separate PR; that template is unchanged.Checklist