Quality review: bump Process-PSModule to v6.1.16

[Marius Storhaug (MariusStorhaug)]

Summary

Quality review of the repository with dependency, workflow, and test updates.

Changes

• Bump Process-PSModule from v5.5.0 to v6.1.16.
  • v6 replaces fixed TEST_* workflow secret inputs with an optional TestData object. This repository does not use test secrets, so no caller changes are required.
• Pass APIKey explicitly instead of using secrets: inherit, matching the v6 secret contract.
• Bump actions/checkout from v7.0.0 to v7.0.1 in Update-FontsData.yml.
• Loosen and bump PowerShell module dependencies in Install-NerdFont.ps1:
  • Fonts: RequiredVersion '1.1.21' → ModuleVersion '1.1.27' with MaximumVersion '1.999.999'.
  • Admin: RequiredVersion '1.1.6' → ModuleVersion '1.1.13' with MaximumVersion '1.999.999'.
  • Note: we initially used '1.*' to match the Pester #Requires style, but Process-PSModule's manifest builder currently fails on wildcard MaximumVersion values (filed Build-PSModuleManifest fails when #Requires MaximumVersion uses wildcards Process-PSModule#444).
• Use system temp directory for downloads ([System.IO.Path]::GetTempPath()) instead of $HOME, so leftover folders live where the OS can clean them up. (Includes PR Use system temp directory for temporary font downloads instead of $HOME #69.)
• Migrate documentation config from .github/mkdocs.yml to .github/zensical.toml for Process-PSModule v6 site generation.
• Add CONTRIBUTING.md because README.md linked to a missing file.
• Add Documentation section to README.md pointing to the generated command reference at psmodule.io/NerdFonts. (Includes PR 📖 [Docs]: README pages now use the standard module landing-page format #85.)
• Fix cache-fallback Pester test by replacing Copy-Item/Move-Item mocks with a real locked cache file, so the fallback path exercises live Copy-Item behavior.
• Fix canonical documentation links in Get-NerdFont and Install-NerdFont comment-based help to end with a trailing slash, matching PSModule source-code test expectations.

Validation

• Invoke-ScriptAnalyzer passes for src/, tests/, and scripts/.
• Local Invoke-Pester runs against the installed module (Process-PSModule builds and installs the module before running tests in CI).

Related

• Process-PSModule v6.0.0 release notes
• Process-PSModule issue #444 — wildcard MaximumVersion support

[Copilot]

Pull request overview

This PR performs a “quality review” update across the NerdFonts PowerShell module repository, focusing on dependency/workflow bumps and small maintenance fixes (documentation + tests) to keep CI and module behavior aligned with upstream PSModule framework changes.

Changes:

• Bump PSModule/Process-PSModule reusable workflow from v5.5.0 to v6.1.16 and update actions/checkout to v7.0.1 in Update-FontsData.yml.
• Loosen #Requires -Modules constraints for Fonts and Admin in Install-NerdFont.ps1 by switching from fixed RequiredVersion to a version range.
• Add CONTRIBUTING.md and adjust the cache-fallback Pester test mocks to avoid unintended mock failures on the cache-write path.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/NerdFonts.Tests.ps1	Adds default mocks for cache-write path in the cache-fallback test (but mock precedence likely needs adjustment).
src/functions/public/Install-NerdFont.ps1	Updates module dependency requirements to a looser version range for Fonts and Admin.
CONTRIBUTING.md	Adds contribution guidelines to match existing README references.
.github/workflows/Update-FontsData.yml	Bumps pinned actions/checkout to v7.0.1.
.github/workflows/Process-PSModule.yml	Bumps pinned PSModule/Process-PSModule reusable workflow to v6.1.16.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Super-linter summary

Language	Validation result
CHECKOV	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSON	Pass ✅
MARKDOWN	Pass ✅
NATURAL_LANGUAGE	Pass ✅
POWERSHELL	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
YAML	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (2)

tests/NerdFonts.Tests.ps1:283

• These comments describe the issue as the "cache-read filter" no longer matching, but the underlying problem is that the cache-write Copy-Item/Move-Item calls don’t match the filtered mock. Rewording will make the intent clearer for future maintenance.

                    [System.IO.FileAccess]::Read,
                    [System.IO.FileShare]::None

CONTRIBUTING.md:12

• The documentation link in this new CONTRIBUTING guide points at msxorg.github.io/docs/Frameworks/Process-PSModule/, but the repo’s existing Process-PSModule reference points contributors to the GitHub README configuration docs. Using the same canonical link here avoids sending contributors to a potentially stale/incorrect URL.

2. Familiarize yourself with the PSModule framework documentation at
   <https://msxorg.github.io/docs/Frameworks/Process-PSModule/>.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (2)

tests/NerdFonts.Tests.ps1:32

• The dynamic module loader relies on Get-ChildItem ordering when dot-sourcing files. File enumeration order can vary across platforms/filesystems, which can make the test harness brittle as additional source files are added. Sort the discovered file lists before dot-sourcing to ensure deterministic module initialization.

        }

        It 'Returns a specific font' {
            $font = Get-NerdFont -Name 'Tinos'
            Write-Verbose ($font | Out-String) -Verbose

CONTRIBUTING.md:36

• Import-Module ./src will fail because src/ does not contain a module manifest (.psd1) or script module (.psm1). Since the tests now import the source tree dynamically, the development instructions should call Pester directly (and optionally reference the test harness) rather than importing ./src.

```powershell
Import-Module ./src
Invoke-Pester

</details>

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Suppressed comments (1)

CONTRIBUTING.md:35

• Import-Module ./src will fail for a fresh checkout because src/ is not an importable PowerShell module directory here (no .psd1/.psm1 under src/). Updating this snippet to import the built/installed module will make the instructions actionable for contributors.

Import-Module ./src
Invoke-Pester

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/PSModule.yml:21

• .github/PSModule.yml now sets Build.Site.Skip: true, which disables the site generation step. That appears to conflict with this PR’s stated goal of migrating the documentation site config to .github/zensical.toml for v6 site generation and linking to generated docs in the README. If the site should still be generated, this should be removed or set to false.

Build:
  Site:
    Skip: true

tests/NerdFonts.Tests.ps1:283

• This test expects Copy-Item to fail due to [System.IO.File]::Open(..., FileShare::None), but on non-Windows runners Copy-Item/File.Copy may not reliably honor these share-mode locks. That can cause the test to stop exercising the cache-fallback path and become a cache-hit test instead.

                $fileLock = [System.IO.File]::Open(
                    $cachedFile,
                    [System.IO.FileMode]::Open,
                    [System.IO.FileAccess]::Read,
                    [System.IO.FileShare]::None