Fix hello-message id enumeration; gate settings tab by permission - #11
Merged
Merged
Conversation
…ssion deleteHello returned a distinguishable 403 for "id exists but belongs to another project" vs. 404 for "id doesn't exist", letting a caller enumerate valid ids across every project one probe at a time. Both cases now scope the DELETE itself to project_id and return an identical 404. Also adds a new example.manage custom permission and gates the Hello Project Settings tab behind it; the sidebar/task-detail/view surfaces stay open to any project member on purpose. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related hardening changes to the example plugin:
deleteHelloreturned a distinguishable 403 for "this id exists but belongs to another project" vs. 404 for "this id doesn't exist at all", letting a caller enumerate valid ids across every project one probe at a time. The delete is now scoped toproject_iddirectly, so both cases return an identical 404.example.manageand gated the Hello Project Settings tab behind it, demonstrating a plugin-specific custom permission on aproject.settings.tabextension point. The sidebar/task-detail/view Hello surfaces are left ungated on purpose, matching their existing read/write bar (projects.writefor mutations).Also bumps the plugin's patch version in
plugin.json.Verification
go test ./...andgo vet ./...pass, including a new regression test for the existence-oracle fix.🤖 Generated with Claude Code