Skip to content

Fixes missassignment of n_faces and n_nodes in fesom_to_ugrid #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyatt-fluidnumerics wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes missassignment of n_faces and n_nodes in fesom_to_ugrid #2810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/parcels/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,8 +778,8 @@ def fesom_to_ugrid(ds: ux.UxDataset) -> ux.UxDataset:
Renames vertical dimensions:
- nz -> zf (vertical layer faces/interfaces)
- nz1 -> zc (vertical layer centers)
- nod2 -> n_face (face)
- elem -> n_node (node)
- nod2 -> n_node (node)
- elem -> n_face (face)

Parameters
----------
Expand All @@ -802,7 +802,7 @@ def fesom_to_ugrid(ds: ux.UxDataset) -> ux.UxDataset:
"""
ds = ds.copy()

for try_dim, target in [("nod2", "n_face"), ("elem", "n_node")]:
for try_dim, target in [("elem", "n_face"), ("nod2", "n_node")]:
if try_dim in ds.dims:
ds = ds.rename_dims({try_dim: target})

Expand Down