Clean up and improve Monitoring and ExternalIntegration acceptance tests - #5793
Merged
johnsimons merged 1 commit intoAug 19, 2026
Merged
Conversation
johnsimons
force-pushed
the
john/acceotance_test_phase3
branch
from
August 19, 2026 00:04
3db52a8 to
f28a9f5
Compare
rbev
approved these changes
Aug 19, 2026
Refactor tests in the Monitoring and ExternalIntegration areas to replace unfalsifiable assertions with meaningful contract checks. Convert manual polling logic to use the sequence helper for better readability and ensure that test doubles are actually invoked to prevent silent passes. Updates the review plan to mark phase 3 as complete.
johnsimons
force-pushed
the
john/acceotance_test_phase3
branch
from
August 19, 2026 21:32
f28a9f5 to
fb99356
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor tests in the Monitoring and ExternalIntegration areas to replace unfalsifiable assertions with meaningful contract checks. Convert manual polling logic to use the sequence helper for better readability and ensure that test doubles are actually invoked to prevent silent passes.
Updates the review plan to mark phase 3 as complete.