Skip to content

Use Particular.Approvals for approvals #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bording merged 1 commit into from
Aug 19, 2026
Merged

Use Particular.Approvals for approvals #5797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
<PackageVersion Include="System.Reflection.MetadataLoadContext" Version="$(RuntimeFrameworkVersion)" />
<PackageVersion Include="System.ServiceProcess.ServiceController" Version="$(RuntimeFrameworkVersion)" />
<PackageVersion Include="Validar.Fody" Version="1.9.0" />
<PackageVersion Include="Verify.NUnit" Version="31.20.0" />
<PackageVersion Include="Yarp.ReverseProxy" Version="2.3.0" />
</ItemGroup>
<ItemGroup Label="Versions to pin transitive references">
Expand Down
1 change: 1 addition & 0 deletions ...ySerializationTests.Response_wraps_roles_and_routes_under_pinned_field_names.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"roles":["admin"],"routes":[{"method":"GET","url_template":"/api/errors"}]}
11 changes: 0 additions & 11 deletions ...ySerializationTests.Response_wraps_roles_and_routes_under_pinned_field_names.verified.txt
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions src/ServiceControl.Infrastructure.Tests/Auth/RouteManifestEntrySerializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
namespace ServiceControl.Infrastructure.Tests.Auth;

using System.Text.Json;
using System.Threading.Tasks;
using NUnit.Framework;
using Particular.Approvals;
using ServiceControl.Infrastructure.Auth;
using VerifyNUnit;

[TestFixture]
class RouteManifestEntrySerializationTests
Expand All @@ -30,12 +29,12 @@ public void Emits_snake_case_field_names_even_under_a_camelCase_policy()
// Same contract as above, but for the response wrapper: roles are reported once at the top level,
// not duplicated onto every route entry.
[Test]
public Task Response_wraps_roles_and_routes_under_pinned_field_names()
public void Response_wraps_roles_and_routes_under_pinned_field_names()
{
var json = JsonSerializer.Serialize(
new MyRoutesResponse(["admin"], [new RouteManifestEntry("GET", "/api/errors")]),
new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });

return Verifier.VerifyJson(json);
Approver.Verify(json);
}
}
2 changes: 1 addition & 1 deletion src/ServiceControl.Infrastructure.Tests/ServiceControl.Infrastructure.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<PackageReference Include="NUnit" />
<PackageReference Include="NUnit.Analyzers" />
<PackageReference Include="NUnit3TestAdapter" />
<PackageReference Include="Verify.NUnit" />
<PackageReference Include="Particular.Approvals" />
</ItemGroup>

</Project>