Add acceptance tests for core ServicePulse API routes - #5810
Merged
Conversation
Adds coverage for the license, heartbeat stats, and failed message query routes as part of the Phase 4 review plan. Includes guidance in documentation on handling eventual consistency in search index assertions and modifies the settings infrastructure to allow overriding the heartbeat grace period in tests.
…itoring Implements the first five journeys of the Phase 4 review plan, covering failed message triage, batch archival and restoration, pending retry resolution, and notification configuration. These tests shift from a per-route model to scenario-based journeys that simulate real operator workflows. This change also fixes a defect in the endpoint settings API where a missing default row could cause UI failures and renames an incorrectly titled pending retry test to reflect its actual behavior.
rbev
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds coverage for the license, heartbeat stats, and failed message query routes as part of the Phase 4 review plan.
Includes guidance in documentation on handling eventual consistency in search index assertions and modifies the settings infrastructure to allow overriding the heartbeat grace period in tests.