Skip to content

Update Soul Cores for PoE2 0.5.5 - #2504

Open
JLawMcGraw wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
JLawMcGraw:update/poe2-055-soul-cores
Open

Update Soul Cores for PoE2 0.5.5#2504
JLawMcGraw wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
JLawMcGraw:update/poe2-055-soul-cores

Conversation

@JLawMcGraw

Copy link
Copy Markdown

Description of the problem being solved:

The Soul Core data on dev predates PoE2 0.5.5. Existing core values changed and 17 new Soul Cores are missing, so imported items can parse with stale values or fail to recognize current socketables.

This refreshes ModRunes and generated stat descriptions from client 4.5.5.1.5, updates affected item expectations, and adds coverage for the complete 0.5.5 Soul Core set.

Steps taken to verify a working solution:

  • Verified all 17 new Soul Cores are present with their current item classes and values.
  • Added data-driven parsing checks for every new core and updated the existing item parsing and Items tab assertions.
  • Ran all 53 system spec files with this change plus the runtime compatibility fix in Fix LuaJIT compatibility on dev #2503: 826 passed, 0 failed, 2 expected failures, 18 pending.

Link to a build that showcases this PR:

N/A; this is generated game data and parser coverage.

Before screenshot:

N/A

After screenshot:

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant