Add NOT filters to trader - #10259
Open
vaisest wants to merge 2 commits into
Open
Conversation
vaisest
commented
Aug 20, 2026
|
|
||
| -- Apply any requests influences | ||
| if options.influence1 > 1 then | ||
| testItem[itemLib.influenceInfo.default[options.influence1 - 1].key] = true |
Contributor
Author
There was a problem hiding this comment.
Apparently the influence controls also set it on the test subject. This probably needs a solution for what cares about influences. We could also maybe generate weights for it
vaisest
marked this pull request as ready for review
August 20, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5581.
Description of the problem being solved:
This adds dropdown selectors for "NOT" filters in the trader. This is accompanied by a refactor of the max filter system to use a complexity budget, which is what the trade site does in reality.
This also makes the popup height dynamic, and adds magical colour to the mod texts.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: