Convert positive late flat skill costs with their resource - #10262
Open
LocalIdentity wants to merge 1 commit into
Open
Convert positive late flat skill costs with their resource#10262LocalIdentity wants to merge 1 commit into
LocalIdentity wants to merge 1 commit into
Conversation
Fix added Total Mana cost when converting to Energy Shield or Life cost. For some reason the game can only add to the base cost but not subtract from it. So modifiers such as `Non-Channelling Skills have -7 to Total Mana Cost` do not reduce Blood Magic life cost but `Non-Channelling Skills have +7 to Total Mana Cost` would increase it. Added tests to cover multiple scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fix added Total Mana cost when converting to Energy Shield or Life cost.
For some reason the game can only add to the base cost but not subtract from it. So modifiers such as
Non-Channelling Skills have -7 to Total Mana Costdo not reduce Blood Magic life cost butNon-Channelling Skills have +7 to Total Mana Costwould increase it.Added tests to cover multiple scenarios
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/zq3dhv0h
Before screenshot:
After screenshot: