Fix rounding of scaled damage conversion percentages - #10263
Open
LocalIdentity wants to merge 2 commits into
Open
Fix rounding of scaled damage conversion percentages#10263LocalIdentity wants to merge 2 commits into
LocalIdentity wants to merge 2 commits into
Conversation
The game rounds every scaled conversion destination to a whole percentage point before summing the converted amount. e.g. Three 40% conversions become 33%, 33%, and 33% instead of the 33.33% PoB currently uses
Only round converted damage at the end instead of the start of the calculation path. This prevents each recursive conversion step from creating or losing damage values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes 2 issues
The game rounds every scaled conversion destination to a whole percentage point before summing the converted amount.
e.g. Three 40% conversions become 33%, 33%, and 33% instead of the 33.33% PoB currently uses
Only round converted damage at the end instead of the start of the calculation path. This prevents each recursive conversion step from creating or losing damage values.
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/rj6khq0i
Before screenshot:
After screenshot: