Fix precision of Critical Strike Chance value - #10264
Open
LocalIdentity wants to merge 1 commit into
Open
Conversation
The game stores crit chance values down to 0.01% but PoB was saving them to 0.001% which technically would be incorrect when using lucky or other extra crit roll chance mods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The game stores crit chance values down to 0.01% but PoB was saving them to 0.001% which technically would be incorrect when using lucky or other extra crit roll chance mods
This was also the reason why you'd sometimes see effective crit chance in the sidebar even when you were accuracy capped and had no lucky crit
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/d63eam0h
Before screenshot:
After screenshot: