Fix skill Area of Effect rounding and minion skill AoE values - #10268
Open
LocalIdentity wants to merge 2 commits into
Open
Fix skill Area of Effect rounding and minion skill AoE values#10268LocalIdentity wants to merge 2 commits into
LocalIdentity wants to merge 2 commits into
Conversation
PoB previously multiplied increased and final Area of Effect as floats and rounded the combined multiplier to two decimals. The game first rounds the final-area percentage, multiplies it by the additive area percentage, and truncates that result before converting area to radius.
The stat `active_skill_area_of_effect_radius_+%_final` was mapped as more Area of Effect instead of more Radius, so a 50% final radius mod gave 22% more radius instead of 50%. Add a test using Carrion Golem Leap Slam. The 15 base radius and 30% final radius now calculate to 19 instead of the 17 it showed before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes 2 area related issues
PoB previously multiplied increased and final Area of Effect as floats and rounded the combined multiplier to two decimals. The game first rounds the final area percentage, multiplies it by the additive area percentage, and truncates that result before converting area to radius.
The stat
active_skill_area_of_effect_radius_+%_finalwas mapped as more Area of Effect instead of more Radius, so a 50% final radius mod gave 22% more radius instead of 50%.Add a test using Carrion Golem Leap Slam.
The 15 base radius and 30% final radius now calculate to 19 instead of the 17 it showed before.
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/i03o100h
Before screenshot:
After screenshot: