Connection pool - #13
Open
282000ypk wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely remove the existing retry mechanism (including for GET calls)
Connection pool implementation for API requests, with the following defaults, all configurable at the merchant (client instance) level:
- Pool size: 10 connections (default)
- Keep-alive: 60s for these connections (default)
- Connect timeout: 3s (default)
- Request (read) timeout: 30s (default), considering autoPay APIs
Update the TokenFetch Service as follows:
- Token should be fetched at instance creation itself instead of waiting for any operation
- In case the first token fetch fails, it can be retried
- Subsequent tokens should be refreshed at half the time before expiry. In case of refresh failure, it can be retried until the token expires
- The token refresh strategy should include a lock mechanism: once the token is refreshed and updated, it should be locked so that no thread other than the refresh thread can modify it