Skip to content

fix: complete Wishiwashi's Schooling form condition - #1636

Merged
Naramsim merged 1 commit into
PokeAPI:masterfrom
MiquelRForgeFlow:master-fix-wishiwashi-forms
Aug 11, 2026
Merged

fix: complete Wishiwashi's Schooling form condition#1636
Naramsim merged 1 commit into
PokeAPI:masterfrom
MiquelRForgeFlow:master-fix-wishiwashi-forms

Conversation

@MiquelRForgeFlow

@MiquelRForgeFlow MiquelRForgeFlow commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Wishiwashi's School form declared the Schooling ability trigger but the Solo form did not, and the two weren't linked. This PR adds the trigger to the Solo form and set base_form on both so the transformation is described bidirectionally (like Minior's Shields Down).

AI coding assistance disclosure

Checking numbers and commit message.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

Wishiwashi's School form declared the Schooling ability trigger but the
Solo form did not, and the two weren't linked. Add the trigger to the
Solo form and set base_form on both so the transformation is described
bidirectionally (like Minior's Shields Down).
@MiquelRForgeFlow
MiquelRForgeFlow force-pushed the master-fix-wishiwashi-forms branch from e81dd6c to 93dab74 Compare August 6, 2026 09:24
@Naramsim
Naramsim merged commit c0a9bc7 into PokeAPI:master Aug 11, 2026
20 checks passed
@Naramsim

Copy link
Copy Markdown
Member

Thanks, I see that the form is changed based on the HP of the pokemon. I guess this is not something that the API can expose, right?

@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user

Copy link
Copy Markdown

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants