Fix the inverted EDUCQUAL to highest_education mapping - #460
Open
juaristi22 wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #459.
The
EDUCQUAL_MAPread the FRS highest-qualification codeframe upside down: code 1 was mapped to NOT_COMPLETED_PRIMARY and codes 17–21 to TERTIARY, but the frame starts at 1 = Doctorate and descends.highest_educationfeeds live model logic (maintenance loan system assignment, DSA course eligibility, student loan plan assignment).This cherry-picks the existing correction from
feat/impute-below-threshold-borrowers(8f95629, authorship preserved) onto main, now verified two independent ways:Under the corrected map the weighted
highest_educationcomposition of the base FRS moves from {TERTIARY 9.9%, POST_SECONDARY 21.3%} to {TERTIARY 28.1%, POST_SECONDARY 8.4%} — expect downstream shifts in student-support and education-conditioned outputs on the next data build.The microcosm migration adopted the same corrected frame as a signed difference in PolicyEngine/microcosm#703, so landing this keeps the two pipelines aligned.
Test suite: 484 passed, 107 skipped (licensed-data tests skip without staged inputs), no failures.
🤖 Generated with Claude Code