fix(hud): prevent flicker when opening/closing OneConfig - #979
Open
saadndm wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hud elements could disappear for one frame causing flickering:
In < 1.21.8: On first open and on every close
In >= 1.21.8: On every close
Caused by the transition between Compose and normal HUD rendering being out of sync
Fixed by making sure either Compose or normal HUD rendering remains visible when control switches to the other, comments explain with more detail
Before (Capped at 10fps to make it visible to recording):
before.mp4
After:
after.mp4
Testing
Tested on 1.21.1, 1.21.4, 1.21.5, 1.21.8, 26.1, 26.2
Checklist