feat: resource packs and shaders quiet reload - #752
Open
rozwader wants to merge 3 commits into
Open
Conversation
…ke 50% of the time (sometimes would, sometimes not)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a feature where resource packs and shaders after installation mid game will appear inside the game, without needing to restart it.
Related Issue(s)
#731
How to test
Warning: I've had a couple bugs where all the textures from inventory would disappear and solo world would be deleted from the worlds list (after relaunch everything was getting fixed). I couldn't recreate this again and everything worked, I assume it was something with Minecraft rather than with Launcher. It would be nice if someone tested it thoroughly, played with adding texturepacks and shaders while being in-game.
Documentation
No