chore: add wif docs for openai/anthropic - #157
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Critical schema ambiguity and missing required-field enforcement must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds OpenAPI documentation and schemas for OpenAI OAuth/WIF and Anthropic WIF integrations.
Changes:
- Adds Python, JavaScript, and cURL examples.
- Documents provider-specific authentication fields and configuration schemas.
- Extends integration request and response definitions.
File summaries
| File | Summary |
|---|---|
openapi.yaml |
Adds authentication examples and provider configuration definitions. |
Review details
Suppressed comments (2)
openapi.yaml:33734
- The descriptions mark the OAuth fields as required for two auth modes, but this schema has no
requiredlist or auth-mode-specific variants. OpenAPI consumers will therefore treat an incomplete WIF/OAuth configuration as valid, despite the contract documented here. Model the auth modes with variants that require their respective fields (while accounting for the shared update schema).
openapi.yaml:33786 - The Anthropic WIF fields are described as required, but none are enforced by this schema. As a result, generated clients and validators accept configurations missing the federation rule, organization, service account, or OAuth credentials. Add auth-mode-specific required variants (and account for partial update semantics) so the published contract matches these descriptions.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sk-portkey
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.