Skip to content

chore: add wif docs for openai/anthropic - #157

Merged
b4s36t4 merged 1 commit into
masterfrom
chore/oauth-wif-update
Sep 11, 2026
Merged

chore: add wif docs for openai/anthropic#157
b4s36t4 merged 1 commit into
masterfrom
chore/oauth-wif-update

Conversation

@b4s36t4

@b4s36t4 b4s36t4 commented Sep 11, 2026

Copy link
Copy Markdown

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Critical schema ambiguity and missing required-field enforcement must be addressed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds OpenAPI documentation and schemas for OpenAI OAuth/WIF and Anthropic WIF integrations.

Changes:

  • Adds Python, JavaScript, and cURL examples.
  • Documents provider-specific authentication fields and configuration schemas.
  • Extends integration request and response definitions.
File summaries
File Summary
openapi.yaml Adds authentication examples and provider configuration definitions.
Review details

Suppressed comments (2)

openapi.yaml:33734

  • The descriptions mark the OAuth fields as required for two auth modes, but this schema has no required list or auth-mode-specific variants. OpenAPI consumers will therefore treat an incomplete WIF/OAuth configuration as valid, despite the contract documented here. Model the auth modes with variants that require their respective fields (while accounting for the shared update schema).
    openapi.yaml:33786
  • The Anthropic WIF fields are described as required, but none are enforced by this schema. As a result, generated clients and validators accept configurations missing the federation rule, organization, service account, or OAuth credentials. Add auth-mode-specific required variants (and account for partial update semantics) so the published contract matches these descriptions.
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread openapi.yaml
Comment thread openapi.yaml
@b4s36t4
b4s36t4 merged commit 010d90c into master Sep 11, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants