feat(channels): add scoped channel foundations (2/4) - #3813
Conversation
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e917958 to
ffc8505
Compare
Extract the task thread conversation behavior and PR artifact presentation used by existing channel surfaces. This is behavior-neutral groundwork for the structured Activity view. Generated-By: PostHog Code Task-Id: 6190e713-9b80-43d9-a05c-5e3b1ecdf297
Generated-By: PostHog Code Task-Id: 6190e713-9b80-43d9-a05c-5e3b1ecdf297
0b813d4 to
e04e1a2
Compare
Add the dormant channel identity, item-list, and task-routing foundations with flag definitions and project-safe cleanup. Visible layout activation remains upstack. Generated-By: PostHog Code Task-Id: 6190e713-9b80-43d9-a05c-5e3b1ecdf297
Generated-By: PostHog Code Task-Id: 6190e713-9b80-43d9-a05c-5e3b1ecdf297
f60bbca to
1496330
Compare
| channelName={channelName} | ||
| channelId={backendChannel?.id} | ||
| channelContextId={channelId} | ||
| allowNoRepo |
There was a problem hiding this comment.
The composer is usable while useBackendChannel(channelName) is still resolving, so a fast submit (or any resolve failure) passes undefined here. Both task creation paths serialize that as no channel, while the presence of channelName also prevents the personal-channel fallback. The task is filed in the desktop folder afterward, but it has no backend channel ownership and therefore never appears in useChannelFeed. Please hold submission until the backend channel UUID is available, and surface resolution failure rather than creating an unscoped task.
Merge activity
|
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |

Problem
Channel spaces need project-safe identity, item loading, and task creation semantics before any visible layout can be activated.
Changes
This is PR 2 of the stack, based on #3812. With either flag state, users still see the existing layout.
How did you test this?
pnpm --filter @posthog/core test -- src/canvas/channelItems.test.ts src/canvas/runStatus.test.tspnpm typecheckinpackages/uiAutomatic notifications
Created with PostHog Code