Skip to content

CODE_STYLE.md: prefer %TYPE over a hardcoded type for column mirrors #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnasbyupgrade merged 2 commits into from
Aug 10, 2026
Merged

CODE_STYLE.md: prefer %TYPE over a hardcoded type for column mirrors #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de09ae
CODE_STYLE.md: prefer %TYPE over a hardcoded type for column mirrors
jnasbyupgrade Aug 10, 2026
143a08a
CODE_STYLE.md: drop NOTICE detail from %TYPE section
jnasbyupgrade Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CODE_STYLE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,20 @@ across Postgres-Extensions repos.
the same comment verbatim in adjacent code — write it once and reference
it ("same as above").

## Prefer `%TYPE` over a hardcoded type

When a function parameter, variable, or column exists to hold a copy of
another table's column value, declare it as `table.column%TYPE` instead of
hardcoding the type. This ties the declaration to the column's actual
type, so a future column type change doesn't silently create a mismatch
that a hardcoded type would miss.

Don't "clean up" an existing `%TYPE` reference by replacing it with the
literal type it currently resolves to — that's removing the exact
protection it exists to provide, not simplifying dead weight (see
[Postgres-Extensions/test_factory#18](https://github.com/Postgres-Extensions/test_factory/pull/18),
where this was done and then reverted).

## Don't set `client_min_messages` inside an extension install script

`CREATE EXTENSION`/`ALTER EXTENSION UPDATE` already forces
Expand Down