Adapt to cat_tools 0.3.0: renamed function, two new object types

[jnasbyupgrade]

Extracted from #5 ("Switch to pgxn-tools based testing"), which had
scope-crept into carrying this fix alongside the actual CI/pgxn-tools
migration. Splitting it out so it can be reviewed and merged on its own.

Update while preparing this PR: it originally also changed the
Makefile's cat_tools target to build from cat_tools' 0.3.0 git tag
directly, working around PGXN's package index being stuck on the broken,
2017-era 0.2.1 release (column "oid" specified more than once at
CREATE EXTENSION cat_tools). That's no longer true -- PGXN's index now
serves 0.3.0 directly (confirmed against the live index, a clean
CREATE EXTENSION cat_tools locally, and #5's now-green CI, all without
any Makefile change). So this PR no longer touches the Makefile at all;
plain pgxn install --unstable cat_tools already resolves to 0.3.0.

What's left: adapting to cat_tools 0.3.0's real API/enum changes

Because cat_tools has apparently never successfully run against
object_reference's full suite before (whatever version was previously
resolved), this surfaced two small, real fixes:

• cat_tools.function__arg_types_text() is deprecated in 0.3.0 in favor
  of cat_tools.routine__parse_arg_types_text() (identical
  signature/body, just renamed) and emits a WARNING on every call.
  Switched sql/object_reference.sql's one call site to the
  non-deprecated name.
• cat_tools 0.3.0's object_type enum grew two new members,
  partitioned table and partitioned index. pg_get_object_address()
  doesn't recognize either (only the base table/index types they
  derive from), so they're classified as unsupported
  (object_reference.unsupported()), matching the existing handling of
  event trigger for the same reason. test/sql/all.sql's sanity-check
  of the unsupported set is updated to match.

sql/object_reference--stable.sql (generated from sql/object_reference.sql)
and test/expected/zzz_build.out are regenerated to match.

Verification

• CREATE EXTENSION cat_tools; standalone on PostgreSQL 17 via plain
  pgxn install --unstable cat_tools: installs cleanly at 0.3.0.
• make test on PostgreSQL 17: all 7 tests pass cleanly, zero diffs.
• test/expected/zzz_build.out's update here is a pure mechanical
  line-number shift (from the added enum-growth comment) plus the
  disappearance of the deprecated-function warning -- matches exactly
  what's already landed and CI-verified on master-pre-rollback (the
  branch Switch to pgxn-tools based testing #5 used to also carry this content on).

No longer anything for #5 to depend on merging first -- #5's CI already
passes cleanly on its own, since PGXN already serves a working cat_tools.
This PR is now a plain correctness/adaptation fix, reviewable and
mergeable independently and in either order relative to #5.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 38f9d2b2-95be-4b2f-8005-8d42077ec9a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Claude finished @jnasbyupgrade's task in 3m 3s —— View job

---

Review of PR #28: Adapt to cat_tools 0.3.0

• Gather context (read PR diff, changed files, CLAUDE.md)
• Understand the request (code review via /code-review)
• Review sql/object_reference.sql changes
• Review test/sql/all.sql changes
• Review test/expected/zzz_build.out changes
• Post review feedback

---

Summary: Small, well-scoped adaptation to cat_tools 0.3.0. No issues found.

What was checked:

1. Deprecated function rename (sql/object_reference.sql:87) — cat_tools.function__arg_types_text(args) → cat_tools.routine__parse_arg_types_text(args). Confirmed this is the only call site in the active source (grep across sql/*.sql shows the old name only remains in the frozen object_reference--0.1.0.sql release snapshot, which correctly isn't touched).

2. New enum members handled as unsupported (sql/object_reference.sql:522-530, test/sql/all.sql:56-62) — partitioned table / partitioned index are added to the unsupported-object-types array and the corresponding pgTAP sanity check, consistently, in both places. The rationale (pg_get_object_address() doesn't recognize these two variants, only the base table/index types they derive from) matches the existing precedent for event trigger. I checked the rest of object_reference.sql for other places that switch/case on object_type (lines ~177-895) — all other logic goes through generic cat_tools.object__address_classid() / pg_get_object_address() calls rather than hardcoded per-type branches, so the unsupported-set update is the only place that needed touching. The broader "all object types are tested" check (test/sql/all.sql:36-47) already derives from cat_tools.enum_range_srf('cat_tools.object_type'), so it will automatically pick up the two new members without further changes.

3. test/expected/zzz_build.out — the diff is a pure line-number shift in the "I promise you will be sorry..." warnings (psql:test/temp_load.not_sql:NNN), consistent with a mechanical regeneration after the source changes above; no unexpected content changes.

4. Confirmed sql/object_reference--stable.sql is correctly not part of the diff — it's gitignored as a build-time artifact (per .gitignore), matching the PR body's note that it's "regenerated" but not committed.

5. META.json/object_reference.control don't pin a cat_tools version (requires = 'cat_tools, count_nulls', unversioned), so no version-bump is needed there.

6. CI is green: CI run passed.

No changes requested — this looks correct, minimal, and consistent with the existing patterns in the codebase.