Skip to content

CI: gate the test job on make verify-results, not make test #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnasbyupgrade merged 2 commits into from
Aug 10, 2026
Merged

CI: gate the test job on make verify-results, not make test #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
565a11c
CI: gate the test job on make verify-results, not make test
jnasbyupgrade Aug 10, 2026
4cd9280
Merge branch 'master' into fix-ci-verify-results
jnasbyupgrade Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,14 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v4
- name: Test on PostgreSQL ${{ matrix.pg }}
run: make test
# `make test` alone never fails this step: pgxntool/base.mk (as
# vendored here, 2.2.0) marks its underlying installcheck .IGNORE,
# so a regression exits 0 and only prints the diff. verify-results is
# the real gate -- it runs the same TEST_DEPS chain, then actually
# inspects the pgTAP results (PGXNTOOL_ENABLE_VERIFY_RESULTS defaults
# to yes, PGXNTOOL_VERIFY_RESULTS_MODE to pgtap, matching this
# suite's pgTAP-based tests) and exits non-zero on failure.
run: make verify-results

# A single stable check name for use as a required status check in branch
# protection rules. Matrix jobs produce check names like "🐘 PostgreSQL 14"
Expand Down
Loading