Skip to content

Bump .vendor/linter: tighten comment-stacked-dashes to 2+ lines #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnasbyupgrade merged 2 commits into from
Aug 12, 2026
Merged

Bump .vendor/linter: tighten comment-stacked-dashes to 2+ lines #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07ca251
Bump .vendor/linter to pick up tightened comment-stacked-dashes rule
jnasbyupgrade Aug 12, 2026
14ac717
Convert 2-line -- comments to /* */ blocks for comment-stacked-dashes
jnasbyupgrade Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vendor/linter
Open in desktop
Submodule linter updated 9 files
+43 −5 .github/workflows/ci.yml
+116 −30 .github/workflows/claude-code-review.yml
+10 −5 .github/workflows/claude.yml
+19 −0 CLAUDE.md
+9 −0 README.md
+5 −5 sql/README.md
+3 −3 sql/bin/sql-lint
+4 −1 sql/test/fixtures/comment-stacked-dashes.bad.sql
+0 −3 sql/test/fixtures/comment-stacked-dashes.good.sql
6 changes: 4 additions & 2 deletions sql/test_factory.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,10 @@ BEGIN
END
$body$;

--select (tf.get('moo','moo')::moo).*;
-- Restore the caller's role saved at the top of this script.
/*
* select (tf.get('moo','moo')::moo).*;
* Restore the caller's role saved at the top of this script.
*/
DO $body$
BEGIN
EXECUTE 'SET ROLE ' || pg_catalog.quote_ident(pg_catalog.current_setting('test_factory.original_role'));
Expand Down
6 changes: 4 additions & 2 deletions test/install/load.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,10 @@ SELECT :'load_mode' = 'existing' AS is_existing
CREATE SCHEMA IF NOT EXISTS tap;
CREATE EXTENSION IF NOT EXISTS pgtap SCHEMA tap;

-- Captured before either branch below runs CREATE EXTENSION, so the
-- role-restore proof after \endif covers whichever one actually ran.
/*
* Captured before either branch below runs CREATE EXTENSION, so the
* role-restore proof after \endif covers whichever one actually ran.
*/
SELECT current_user AS role_before_install
\gset

Expand Down
Loading