Skip to content

Refactor New-CommandDataFile script#2197

Open
sdwheeler wants to merge 2 commits into
PowerShell:mainfrom
sdwheeler:sdw-w600137-refactor-script
Open

Refactor New-CommandDataFile script#2197
sdwheeler wants to merge 2 commits into
PowerShell:mainfrom
sdwheeler:sdw-w600137-refactor-script

Conversation

@sdwheeler

@sdwheeler sdwheeler commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Refactor New-CommandDataFile script

  • Fixes AB#600137

This PR rewrites the script to create a function and fixes several issues:

  • Adds comment-based help
  • Adds parameter to specify an output path for the JSON file
  • Fixes the logic to avoid duplicate data output
  • Outputs a FileInfo object for the newly created file

@sdwheeler
sdwheeler requested review from a team and bergmeister as code owners July 25, 2026 23:47
Copilot AI review requested due to automatic review settings July 25, 2026 23:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors Utils/New-CommandDataFile.ps1 into an advanced script/function that generates the command/alias JSON data file used for compatibility-related settings, adding an OutputPath parameter and modernizing the implementation.

Changes:

  • Converts the script logic into an advanced function (New-CommandDataFile) and calls it from the script entrypoint.
  • Adds OutputPath support and uses module-qualified cmdlet invocations throughout.
  • Reworks module/command/alias enumeration and JSON emission.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Utils/New-CommandDataFile.ps1 Outdated
Comment thread Utils/New-CommandDataFile.ps1
Comment thread Utils/New-CommandDataFile.ps1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants