Skip to content

Fix invalid JSON manifest schema URL references to the live Plaster schema - #478

Merged
HeyItsGilbert merged 3 commits into
mainfrom
copilot/fix-schema-url-in-manifest
Sep 19, 2026
Merged

HeyItsGilbert merged 3 commits into
mainfrom
copilot/fix-schema-url-in-manifest

Conversation

Copilot AI commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Generated and sample JSON manifests referenced a non-existent schema URL (.../v2/schema/...), causing editor schema loading to fail with 404 and breaking validation/autocomplete. This PR repoints schema references to the current raw schema location in this repository.

  • Runtime manifest generation

    • Updated JSON $schema emitted by:
      • New-PlasterManifest
      • ConvertTo-JsonManifest
      • New-JsonManifestStructure
  • Schema identity and repository examples

    • Updated schema $id in Plaster/Schema/plaster-manifest-v2.json to the same reachable URL.
    • Updated all user-facing JSON examples/demos and README snippets to remove stale v2 links.
  • Regression coverage

    • Tightened focused assertions so JSON output checks the exact $schema value (not just presence), preventing drift back to invalid URLs.
{
  "$schema": "https://raw.githubusercontent.com/PowerShellOrg/Plaster/main/Plaster/Schema/plaster-manifest-v2.json",
  "schemaVersion": "2.0"
}

Co-authored-by: HeyItsGilbert <615265+HeyItsGilbert@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix invalid schema URL in module manifest Fix invalid JSON manifest schema URL references to the live Plaster schema Sep 19, 2026
Copilot AI requested a review from HeyItsGilbert September 19, 2026 15:40
@HeyItsGilbert
HeyItsGilbert marked this pull request as ready for review September 19, 2026 15:41
Copilot AI lite review requested due to automatic review settings September 19, 2026 15:41
Co-authored-by: HeyItsGilbert <615265+HeyItsGilbert@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

All reviewed changes align with the intended schema URL fix, with no unresolved review issues.

Review effort: Lite
Findings: None

What changed in this PR

This PR updates invalid JSON manifest schema references to the live Plaster schema URL.

Changes:

  • Updated generated manifest schema URLs and schema identity.
  • Updated README, examples, demos, and test fixtures.
  • Added exact schema URL regression assertions.
File Description
tests/​New-PlasterManifest.Tests.ps1 Verifies generated schema URL
tests/​ConvertTo-JsonManifest.Tests.ps1 Verifies converted schema URL
tests/​ConditionEval.Tests.ps1 Updates JSON fixtures
README.md Updates JSON example
Plaster/​Schema/​plaster-manifest-v2.json Updates schema identity
Plaster/​Public/​New-PlasterManifest.ps1 Updates generated URL
Plaster/​Public/​ConvertTo-JsonManifest.ps1 Updates converted URL
Plaster/​Private/​New-JsonManifestStructure.ps1 Updates generated structure
examples/​TemplateModule/​TemplateTwo/​plasterManifest.json Updates example
examples/​TemplateModule/​TemplateOne/​plasterManifest.json Updates example
examples/​plasterManifest.json Updates example
examples/​plasterManifest-validatePattern.json Updates example
examples/​plasterManifest_fr-FR.json Updates example
examples/​NewPowerShellScript/​plasterManifest.json Updates example
examples/​NewModule/​plasterManifest.json Updates example
demos/​templates/​03-json-module/​plasterManifest.json Updates demo
demos/​templates/​02-json-greeter/​plasterManifest.json Updates demo

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@HeyItsGilbert
HeyItsGilbert merged commit 104eec8 into main Sep 19, 2026
@HeyItsGilbert
HeyItsGilbert deleted the copilot/fix-schema-url-in-manifest branch September 19, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The schema from the example doesnt point to valid url

3 participants