Fix invalid JSON manifest schema URL references to the live Plaster schema - #478
Merged
Merged
Conversation
Co-authored-by: HeyItsGilbert <615265+HeyItsGilbert@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invalid schema URL in module manifest
Fix invalid JSON manifest schema URL references to the live Plaster schema
Sep 19, 2026
HeyItsGilbert
approved these changes
Sep 19, 2026
Co-authored-by: HeyItsGilbert <615265+HeyItsGilbert@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes align with the intended schema URL fix, with no unresolved review issues.
Review effort: Lite
Findings: None
What changed in this PR
This PR updates invalid JSON manifest schema references to the live Plaster schema URL.
Changes:
- Updated generated manifest schema URLs and schema identity.
- Updated README, examples, demos, and test fixtures.
- Added exact schema URL regression assertions.
| File | Description |
|---|---|
tests/New-PlasterManifest.Tests.ps1 |
Verifies generated schema URL |
tests/ConvertTo-JsonManifest.Tests.ps1 |
Verifies converted schema URL |
tests/ConditionEval.Tests.ps1 |
Updates JSON fixtures |
README.md |
Updates JSON example |
Plaster/Schema/plaster-manifest-v2.json |
Updates schema identity |
Plaster/Public/New-PlasterManifest.ps1 |
Updates generated URL |
Plaster/Public/ConvertTo-JsonManifest.ps1 |
Updates converted URL |
Plaster/Private/New-JsonManifestStructure.ps1 |
Updates generated structure |
examples/TemplateModule/TemplateTwo/plasterManifest.json |
Updates example |
examples/TemplateModule/TemplateOne/plasterManifest.json |
Updates example |
examples/plasterManifest.json |
Updates example |
examples/plasterManifest-validatePattern.json |
Updates example |
examples/plasterManifest_fr-FR.json |
Updates example |
examples/NewPowerShellScript/plasterManifest.json |
Updates example |
examples/NewModule/plasterManifest.json |
Updates example |
demos/templates/03-json-module/plasterManifest.json |
Updates demo |
demos/templates/02-json-greeter/plasterManifest.json |
Updates demo |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
HeyItsGilbert
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated and sample JSON manifests referenced a non-existent schema URL (
.../v2/schema/...), causing editor schema loading to fail with 404 and breaking validation/autocomplete. This PR repoints schema references to the current raw schema location in this repository.Runtime manifest generation
$schemaemitted by:New-PlasterManifestConvertTo-JsonManifestNew-JsonManifestStructureSchema identity and repository examples
$idinPlaster/Schema/plaster-manifest-v2.jsonto the same reachable URL.v2links.Regression coverage
$schemavalue (not just presence), preventing drift back to invalid URLs.{ "$schema": "https://raw.githubusercontent.com/PowerShellOrg/Plaster/main/Plaster/Schema/plaster-manifest-v2.json", "schemaVersion": "2.0" }