Preserve Meetup event times in calendar feed - #210
Merged
Merged
Conversation
✅ Deploy Preview for powershellorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The iCalendar template drops existing cancellation status serialization when adding the all-day field.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates Meetup synchronization and iCalendar generation to preserve event timestamps and support all-day events.
Changes:
- Preserve structured-data start/end instants.
- Add all-day event handling and correct the September 16 event.
- Run Meetup synchronization tests in CI.
File summaries
| File | Description |
|---|---|
layouts/_partials/event.ics |
Adds all-day date handling. |
content/calendar/meetup-316490583.md |
Corrects event timing. |
.github/workflows/build.yml |
Runs synchronization tests. |
.github/scripts/sync-meetup-events.test.mjs |
Tests timestamp preservation. |
.github/scripts/sync-meetup-events.mjs |
Serializes Meetup event times. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ` "contact" (cond (and .Params.orga .Params.orgaEmail) (dict "text" (printf "%s: %s" .Params.orga .Params.orgaEmail) "lang" $lang) nil) `` ` | ||
| ` "color" "7C3AED" `` ` | ||
| ` "status" (cond (.Params.cancelled | default false) "CANCELLED" "CONFIRMED") `` ` | ||
| ` "allDay" $allDay `` ` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VALUE=DATEpropertiesVerification
node --test .github/scripts/sync-meetup-events.test.mjsnpm run buildnode scripts/validate-calendar.mjs public/calendar/calendar.ics