Skip to content

Make smart pointer operator bool() explicit #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuuuoyue merged 2 commits into from
Apr 8, 2026
Merged

Make smart pointer operator bool() explicit #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd77f0
Initial plan
Copilot Apr 8, 2026
9258956
Make smart pointer operator bool() explicit to prevent implicit conve…
Copilot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/PrettyMemory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ namespace prtm
ConstPointer Data() const { return Get(); }

/** @brief Check whether this ShadowPtr points to a live object. */
operator bool() const { return nullptr != Get(); }
explicit operator bool() const { return nullptr != Get(); }

/** @brief Check whether the referenced object has expired. */
bool Expired() const { return nullptr == Get(); }
Expand Down Expand Up @@ -604,7 +604,7 @@ namespace prtm
ConstPointer operator->() const { return Get(); }

/** @brief Check whether this OwnerPtr currently owns an object. */
operator bool() const { return nullptr != Get(); }
explicit operator bool() const { return nullptr != Get(); }

/** @brief Check whether this OwnerPtr is null. */
bool IsNull() const { return nullptr == Get(); }
Expand Down
Loading