feat(accuracy): propagate end-to-end guarantees for nested summaries (#172) - #303
Open
zzylol wants to merge 4 commits into
Open
feat(accuracy): propagate end-to-end guarantees for nested summaries (#172)#303zzylol wants to merge 4 commits into
zzylol wants to merge 4 commits into
Conversation
…y-guarantee-propagation-172"" This reverts commit 5c6489b.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens the work originally proposed in #299 for review. Refs #172.
This PR is intentionally not configured for auto-merge. It restores the reviewed branch state after #302 reverted the premature merge, so the accuracy model and planner integration can be evaluated before any merge decision.
Scope
AccuracyModelthat fails closed for unsupported or cross-metric compositions.Soundness boundaries
EpsilonDeltarequirement.Deliberately deferred
Issue #172 should remain open after this PR because those items are not implemented here.
Runtime prerequisites for completing the deferred guarantees
The four deferred sketch guarantees cannot be completed soundly by changing planner metadata alone. They require coordinated changes in the actual sketch runtime (
ProjectASAP/asap_sketchlib/sketchlib-go, or whichever implementation serves the finalized plan) and then corresponding integration in ASAPPlanner.Runtime work required:
L2norm and use CountSketch-specific width/depth sizing. The runtime contract must support a statement of the form|f_hat(x) - f(x)| <= epsilon * ||f||_2with failure probability at mostdelta; the CMSL1formula must not be reused.k, so the planner can derive both normalized rank error and failure probability from committed parameters.(epsilon, delta)guarantee.Planner work required after those runtime contracts exist:
(epsilon, delta)budget using the same theorem implemented by the runtime.ResultGuaranteeprovenance and evaluate the symbolicL2, margin, and shared-grid terms.Merely recording the requested
deltainSketchParamsis not sufficient: it would claim confidence without changing the executed algorithm or providing evidence that the probability bound holds. These capabilities should therefore be delivered as linked runtime and planner changes rather than asserted solely in this PR.Validation
cargo fmt --allcargo test --workspace(212 mapping unit tests plus all workspace suites)cargo clippy --workspace --all-targets -- -D warningsgit diff --checkAll pass locally.
Review focus