Skip to content

feat(asap-query-engine): support wider lookback windows over sliding precomputes - #640

Merged
milindsrivastava1997 merged 10 commits into
mainfrom
issue-554-query-window-composition
Aug 27, 2026
Merged

feat(asap-query-engine): support wider lookback windows over sliding precomputes#640
milindsrivastava1997 merged 10 commits into
mainfrom
issue-554-query-window-composition

Conversation

@milindsrivastava1997

@milindsrivastava1997 milindsrivastava1997 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #557 .

  • Compose exact-multiple lookbacks from non-overlapping sliding precompute windows.
  • Align evaluation timestamps down to the complete slide grid and fall back atomically when constituents are missing.
  • Validate value/key grid compatibility for SetAggregator and DeltaSetAggregator. DeltaSetAggregator is accepted only when its tumbling window is a multiple of the sliding step and the sliding window is a multiple of the tumbling window.
  • Update cleanup sizing for composed sliding windows.
  • Add TDD coverage across instant, range, PromQL, SQL, and precompute-equivalence paths.

Validation

  • cargo test -p query_engine_rust --lib
  • cargo test -p asap_planner --lib
  • cargo clippy -p query_engine_rust --lib --tests -- -D warnings
  • Repository pre-commit hooks (format, check, clippy, tests)

@milindsrivastava1997 milindsrivastava1997 changed the title Support wider lookback windows over sliding precomputes feat(asap-query-engine): support wider lookback windows over sliding precomputes Aug 27, 2026
@milindsrivastava1997
milindsrivastava1997 marked this pull request as ready for review August 27, 2026 13:28
@milindsrivastava1997
milindsrivastava1997 merged commit 4ce87d5 into main Aug 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support sliding window candidates in the query engine (execution)

1 participant