SPL: AOT SplFileObject getCsvControl/setCsvControl (#33369) - #33375
Closed
PurHur wants to merge 1 commit into
Closed
SPL: AOT SplFileObject getCsvControl/setCsvControl (#33369)#33375PurHur wants to merge 1 commit into
PurHur wants to merge 1 commit into
Conversation
Materialize the CSV delimiter triple as object string props and return a packaged hashtable via __hashtable__setStringAt (thin-AOT NestedJIT HT unsafe). Defaults match php-src; CSV props sit after SplFileInfo slots. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-33369-splfileobject-csvcontrol
branch
from
August 21, 2026 11:03
ed98068 to
5934c9c
Compare
Owner
Author
|
Superseded by merged #33374 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SplFileObject::getCsvControl/setCsvControlstore the CSV delimiter triple on__spl_csv_{sep,enc,esc}and materialize[sep,enc,esc]via__hashtable__setStringAt+__value__writeHashtable(same thin-AOT pattern as AOT: SplFileObject::fstat() returns empty — Zend size/mode array (ext/spl/spl_directory.c) #33359 fstat — NestedJIT HT returns are unsafe).",",",\); props registered after SplFileInfo slots so inheritedisFile/getSizeindices stay stable.runtime/*.c. php-src:ext/spl/spl_directory.czim_SplFileObject_{get,set}CsvControl.Closes #33369
Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/docker-exec.sh -- bash -lc '… compile + run test/repro/splfileobject_csvcontrol_aot.php'→ctl=["\",","\"","\\"]/ctl2=[";","\"","\\"](5× AOT earlier; 1× after prop-order fix)./script/phpunit.sh --filter SplFileObjectCsvControl33369AotTest→ OK (2 tests, 14 assertions)splfileobject_fgetcsv_aot.php→row=["a","b"];splfileobject_stat_methods_aot.php→file=1/size=2Made with Cursor