Self-host: sync spine for Reflection internal-function JIT (#35699) - #35704
Merged
Conversation
#35699 landed ReflectionInternalFunction* + ReflectionParameter/Type JIT units in inventory but omitted them from compiler_lib_spine_smoke, breaking north-star5-verify-fast and user_release_ready spine-coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_onceentries tocompiler_lib_spine_smoke/main.phpfor Reflection internal-function JIT units landed in AOT: Reflection metadata for internal functions (#28780) #35699 (Regression: unixtojd(PHP_INT_MAX) returns huge int not false; Reflection missing int|false (re-#24863, ext/calendar/cal_unix.c) #28780)Root cause: #35699 added
ReflectionInternalFunction*/ReflectionParameter*/ReflectionType*inventory without spine sync —north-star5-verify-fastanduser_release_readyspine-coverage gate were red.Test plan
php script/check-selfhost-spine-coverage-sync.php→ OK (8001/8001)make north-star5-verify-fast→ OK./script/aot-smoke.sh→ 8/8./script/phpunit.sh --filter testCompilerLibSpineSmokeBundleUnitCountAndKeyUnits→ OK (1 test, 530 assertions)php script/check-wave3-roadmap-sync.php→ OK (spine 8001/8001)note: spine-sync only — no gen-0 manifest restamp.
Made with Cursor