AOT: DOMXPath //@* NodeList::item(N>0) host-fold materialization (#32003) - #35706
Merged
Conversation
). Compile-time attribute-axis queries only cached item(0); item(1+) fell through to DomNodeListItemRuntime and segfaulted. Materialize further indices from the host Zend node-set and extend the AOT fixture to cover star1/star2. php-src: ext/dom/xpath.c attribute axis node-set iteration. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 29, 2026
…5730) Recent DOM AOT landings (#35706–#35726) invalidated committed helper-unit fingerprints; cold builds were re-emitting locally. Targeted per-unit emit + publish restores 441/441 fresh without a full corpus sweep. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMNodeList::item(N)is called withN > 0on host-folded XPath attribute-axis node-sets (//@*,//a/@*,//attribute::*, etc.).item(0)viaDomUserScriptElementCacheLlvm; further indices fell through toDomNodeListItemRuntimeand crashed.item(N)from the host Zend node-set at compile time (JitDomXPathQueryUserScript::hostXPathAxisNodeAt+JitDomNodeListItemUserScript::materializeNthXPathAxisMatch).dom_xpath_attr_star.phptto assertstar1/star2node names.php-src reference:
ext/dom/xpath.c— attribute axis node-set in document order.Verification
Not covered
test/repro/maintainer_gap_dom_xpath_attr_star.php); per-list snapshot follow-up needed../script/release-readiness.shnot run (Pillar 1 probe owned separately).Closes #32003
Made with Cursor