Self-host: sync spine for TypedPropertyClassAssignCheck (#35705, #8703) - #35709
Closed
PurHur wants to merge 1 commit into
Closed
Self-host: sync spine for TypedPropertyClassAssignCheck (#35705, #8703)#35709PurHur wants to merge 1 commit into
PurHur wants to merge 1 commit into
Conversation
#35705 added lib/JIT/TypedPropertyClassAssignCheck.php to inventory but omitted it from compiler_lib_spine_smoke, breaking north-star5-verify-fast spine-coverage and user_release_ready. Refresh gen-0 sidecar stamp and bootstrap-inventory.md (8002 Phase A files). Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/TypedPropertyClassAssignCheck.phptocompiler_lib_spine_smoke(landed in AOT: fix bare self/parent typed property assigns from locals (#31835) #35705 but spine sync was missed)prelinked/bootstrap-gen0/.m3_compiler_lib_sidecar.shato match spine entry SHA-1docs/bootstrap-inventory.md(8002 Phase A files)Why
north-star5-verify-fastfailed step 2: spine coverage missingTypedPropertyClassAssignCheck.php, blockinguser_release_readyspine-coverage gate.Test plan
php script/check-selfhost-spine-coverage-sync.php→ OK (8002/8002)php script/check-selfhost-spine-sidecar-sync.php→ OKmake north-star5-verify-fast→ OK (8017/8017)./script/aot-smoke.sh→ 8/8./script/phpunit.sh --filter 'BootstrapSelfhostBundleTest::testCompilerLibSpineSmokeBundleUnitCountAndKeyUnits|TypedPropSelfParent31835AotTest'→ OKMade with Cursor