AOT: mb_strcut() null length via isNullConstant sentinel (#35711) - #35712
Merged
Conversation
…). JitMbStrcut missed isNullConstant on argument #3, so mb_strcut($s, -N, null) hit JitStrictIntArg and threw TypeError while peer JitMbSubstr already mapped null to the -1 omit-length sentinel. Add repro + MbNegativeOffsetNullLengthAotTest. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitMbStrcutnow treats null literal length like peerJitMbSubstr(isNullConstant→-1omit sentinel) instead of falling through toJitStrictIntArgand throwingTypeError.MbNegativeOffsetNullLengthAotTestfor negative offset + null length (strict and non-strict).php-src:
ext/mbstring/mbstring.c—PHP_FUNCTION(mb_strcut)soft-null length (#21430).Test plan
Closes #35711
Made with Cursor