AOT: ZipArchive addFile/replaceFile keep file bytes after close/reopen (#35449/#35496) - #35714
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZipArchive::addFile()andreplaceFile()passedfile_get_contentspayloads throughZipArchiveJitHelper::exec()$s2string formals; under thin AOT that aliasing dropped bytes, producing empty zip entries afterclose()/open()(peer Fix ZipArchive addFromString AOT entry names (#35454) #35710 / AOT: ZipArchive::addFromString second call overwrites first entry — archive loses prior files (ext/zip/php_zip.c) #35454addEntry).addEntry()(addFile) and newreplaceEntry()(replaceFile); registerreplaceEntryinZipArchiveEmbedBridge.ZipArchiveAddFile35449AotTest; refresh replaceFile dispatch assertion.php-src:
ext/zip/php_zip.c—zim_ZipArchive_addFile,zim_ZipArchive_replaceFileTest plan
Reopens #35449, #35496
Made with Cursor